<html>
<head><meta charset="utf-8"><title>Dogfood test is broken · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html">Dogfood test is broken</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="226174798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226174798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226174798">(Feb 12 2021 at 18:08)</a>:</h4>
<p>I noticed the dogfood test didn't seem to be working. I ran a bisect and it landed on <a href="https://github.com/rust-lang/rust-clippy/issues/6687">rust-lang/rust-clippy#6687</a> which kinda makes sense...</p>



<a name="226181433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226181433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226181433">(Feb 12 2021 at 19:04)</a>:</h4>
<p>For you locally or in some CI?</p>



<a name="226182397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226182397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226182397">(Feb 12 2021 at 19:12)</a>:</h4>
<p>Both. First I noticed multiple things not getting caught in <a href="https://github.com/rust-lang/rust-clippy/pull/6717">https://github.com/rust-lang/rust-clippy/pull/6717</a>.</p>



<a name="226182421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226182421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226182421">(Feb 12 2021 at 19:13)</a>:</h4>
<p>match_like_matches (now fixed) and star import</p>



<a name="226182909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226182909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226182909">(Feb 12 2021 at 19:17)</a>:</h4>
<p>Oh it does _not_ detect things. That's weird</p>



<a name="226183878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226183878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226183878">(Feb 12 2021 at 19:26)</a>:</h4>
<p>I just tested it locally and it worked.</p>



<a name="226190291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226190291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226190291">(Feb 12 2021 at 20:15)</a>:</h4>
<p>Hmm you added lintable code and it failed as expected?</p>



<a name="226191287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226191287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226191287">(Feb 12 2021 at 20:23)</a>:</h4>
<p>I added a dummy <code>span_lint</code> on any block expr, and it linted as exppected</p>



<a name="226192556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226192556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226192556">(Feb 12 2021 at 20:34)</a>:</h4>
<p>Can you try triggering an existing lint?</p>



<a name="226197059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226197059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226197059">(Feb 12 2021 at 21:14)</a>:</h4>
<p>Oh yeah, you're right. It doesn't trigger on Clippy itself, but only on the subprojects <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="226198776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226198776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226198776">(Feb 12 2021 at 21:32)</a>:</h4>
<p>Why are clippy_lints and others <em>not</em> subprojects?</p>



<a name="226198789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226198789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226198789">(Feb 12 2021 at 21:32)</a>:</h4>
<p>Maybe they need to be?</p>



<a name="226198842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226198842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226198842">(Feb 12 2021 at 21:33)</a>:</h4>
<p>Until now <code>clippy_lints</code> was linted as a dep to <code>clippy</code>. But maybe now <code>--no-deps</code> is auto-enabled?</p>



<a name="226199960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226199960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226199960">(Feb 12 2021 at 21:43)</a>:</h4>
<p>I do see discussion about path dependencies with regard to RUSTC_WORKSPACE_WRAPPER. Don't totally understand the implications of these variables. Might need to set CARGO_PRIMARY_PACKAGE somewhere...</p>



<a name="226205163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Dogfood%20test%20is%20broken/near/226205163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Dogfood.20test.20is.20broken.html#226205163">(Feb 12 2021 at 22:30)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> Alas! It works if we have <code>[workspace]</code> in Cargo.toml</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>